Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-10909

Change from kingpin in the client package breaks automation

Details

    • Bug
    • Status: Done
    • Critical
    • Resolution: Fixed
    • 2.31.0
    • 2.33.0
    • PMM Client
    • 1
    • Yes
    • Yes
    • Implex
    • Hide

      1. Run PMM Server

      2. Create a file /home/ihor/work/tasks/PMM_10909/client/pmm-admin-mysql.conf

      3. Execute command:

      cat <<EOF >/home/ihor/work/tasks/PMM_10909/client/pmm-admin-mysql.conf
      --username=pmm
      --password=pmmpassword
      EOF

      4. Run MySQL instance with following env variables:

      • MYSQL_ROOT_PASSWORD=root-password

      5. Add MySQL to monitoring using @file:

      pmm-admin add mysql @/home/ihor/work/tasks/PMM_10909/client/pmm-admin-mysql.conf

      6. Verify that MySQL is added to monitoring successfully

      Show
      1. Run PMM Server 2. Create a file /home/ihor/work/tasks/PMM_10909/client/pmm-admin-mysql.conf 3. Execute command: cat <<EOF >/home/ihor/work/tasks/PMM_10909/client/pmm-admin-mysql.conf --username=pmm --password=pmmpassword EOF 4. Run MySQL instance with following env variables: MYSQL_ROOT_PASSWORD=root-password 5. Add MySQL to monitoring using @file: pmm-admin add mysql @/home/ihor/work/tasks/PMM_10909/client/pmm-admin-mysql.conf 6. Verify that MySQL is added to monitoring successfully

    Description

      Impact on the user
      Automation is broken and cannot be used with >=2.31.0

      Steps to reproduce

      • Use 2.30.0
      • Install the client
      • Create a file to contain all flags
      • Add a service, e.g. pmm-admin add mysql @/path/to/file
      • Remove service
      • Upgrade client to 2.31.0
      • Add a service, e.g. pmm-admin add mysql @/path/to/file

      Actual result
      Failure to register the service

      Expected Result
      Successfully registering the service

      Workaround
      N/A

      Details
      A flags file is used for the following reasons:

      • it allows detection of a change in configuration via automation
      • it hides secrets from the command line
      • it works with all technologies allowing a single template to render the file for use
      • it avoids convoluted ways to support automating all kinds of configurations

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              ceri.williams Ceri Williams
              Votes:
              2 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Smart Checklist