Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-1668

Non-informative error messages during pmm-admin add mysql:queries, duplicate error codes for the same error in percona-qan-agent-installer

    Details

    • Type: Bug
    • Status: Done
    • Priority: High
    • Resolution: Cannot Reproduce
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: PMM Client, QAN Agent
    • Labels:
      None

      Description

      Zendesk 210611
      pmm-admin add mysql --user root --password ****
      [linux:metrics] OK, already monitoring this system.
      [mysql:metrics] OK, now monitoring MySQL metrics using DSN root:***@unix(/tmp/mysql.sock)
      [mysql:queries] Error adding MySQL queries: problem with agent registration on QAN API: exit status 1

      grep os.Exit bin/percona-qan-agent-installer/main.go
      // It flag is unknown it exist with os.Exit(10),
      // NOTE: standard flag.Parse() was using os.Exit(2)
      os.Exit(1)
      os.Exit(1)
      os.Exit(1)
      os.Exit(1)
      os.Exit(1)
      os.Exit(0)

      Expected behaviour:

      • Print whole output in pmm-admin
      • Do not use duplicate error codes

        Smart Checklist

          Attachments

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                nickolay.ihalainen Nickolay Ihalainen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: