Details
-
Improvement
-
Status: Done
-
Low
-
Resolution: Done
-
2.0.0-beta2, 2.0.0
-
1
-
Yes
Description
On https://jira.percona.com/browse/PMM-2880 the favicon usage was discussed, and two of them were proposed:
https://www.percona.com/sites/default/files/icon_0.png
https://www.percona.com/favicon.ico
It seems we are using the latter, which is of way less resolution.
... <link rel="icon" type="image/x-icon" href="public/img/percona-favicon.ico"> ...
From code:
https://github.com/percona/pmm-server/blob/master/landing-page/index.html#L5
https://raw.githubusercontent.com/percona/pmm-server/master/landing-page/img/favicon.ico
References from latest pull on pmm-server github project:
SHELL> grep -Ri "favicon" * landing-page/index.html: <link rel="icon" href="img/favicon.ico" type="image/png"/> password-page/src/index.html: <link rel="icon" type="image/x-icon" href="favicon.ico"> password-page/angular.json: "src/favicon.ico" password-page/angular.json: "src/favicon.ico" password-page/dist/index.html: <link rel="icon" type="image/x-icon" href="favicon.ico">
In case it helps 
These references are from PMM v1, but the same applies to v2-beta
https://github.com/percona/pmm-server/blob/PMM-2.0/landing-page/index.html#L5
...
This ticket is created so that we can start using the png one (or some other that looks better than the one we have now, in which you can clearly see some white pixels at the borders).
Thanks!
