Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-4543

Do not replace pmm-agent.yaml on upgrade

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: 2.0.0-beta5
    • Fix Version/s: 2.0.0-beta7
    • Component/s: Packaging
    • Labels:
      None

      Description

      PMM-3560 says:

      Add single empty file config.yml. Put it into pmm-submodules repository. Install it to <insert proper path there, /usr/local/percona/something> only if this file is not present. Do not replace it or change permissions otherwise.

      But it seems we do overwrite that file (/usr/local/percona/pmm-agent.yaml) on Debian/Ubuntu . That needs to be checked and fixed.

      After discussion with Evgeniy Patlan, we decided on the following:

      1. pmm-agent.yaml is not a part of the package (in a technical sense). That allows us not to overwrite that file during the upgrade, do not ask the user for confirmation during the upgrade, do not "fix" (actually, break) file permissions during the upgrade.
      2. We do create that (empty) file if it does not exist during installation; we use hooks for that.
      3. We do remove that file when purge or equivalent option is used; we use hooks for that.
      4. Upgrade from any previous version to the version with this change (to be released as a part of beta7) will remove pmm-agent.yaml for the last time. That will happen on all distributions.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            alexey.palazhchenko Alexey Palazhchenko
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - Not Specified
                Not Specified
                Logged:
                Time Spent - 1 day, 2 hours, 46 minutes
                1d 2h 46m

                  Smart Checklist