Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-4597

Return default/zero values in API

    XMLWordPrintable

    Details

    • Type: Admin & Maintenance Task
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 2.11.0
    • Component/s: PMM ManageD
    • Labels:
      None
    • Sprint:
      Platform Sprint 26
    • Needs Review:
      Yes
    • Needs QA:
      Yes

      Description

      https://godoc.org/github.com/golang/protobuf/jsonpb#Marshaler allows `EmitDefaults` configuration. We should enable it to make our API responses more clear.

      it is hidden behind a feature flag PERCONA_TEST_NICER_API.

      • Frontend team should check that everything still works with a feature flag.
      • Manual QA with a feature flag.

       

      How to test:

      Run pmm-server docker image with env var PERCONA_TEST_NICER_API=1.
      Check in swagger that API returns all fields, even empty values.

      Check that UI works correctly.

      • Inventory pages and adding new services via UI
      • Sign-in, Sign-up and e.t.c. related to SaaS
      • QAN
      • Settings
      • Database Checks

      Check that pmm-admin commands works.

      • old pmm-admin, new pmm-managed
      • new pmm-admin, new pmm-managed

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              alexey.palazhchenko Alexey Palazhchenko (Inactive)
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 1 hour
                  1h

                    Smart Checklist