Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-4800

Make tablestat messages more descriptive with respect to current status and limits for automatically disabling

Details

    • New Feature
    • Status: Done
    • High
    • Resolution: Done
    • None
    • 2.2.0
    • None
    • None

    Description

      Help text and outputs should be more user-friendly.

      Current help text:

      $ pmm-admin add mysql --help
      
      usage: pmm-admin add mysql [<flags>] [<name>] [<address>]
      
      […]
            --disable-tablestats       Disable table statistics collection
            --disable-tablestats-limit=DISABLE-TABLESTATS-LIMIT
                                       Table statistics collection will be disabled if there are more than specified number of tables (default: server-defined)
      […]
      

      Currently possible outputs:

      MySQL Service added.
      Service ID  : /service_id/1
      Service name: mysql-1
      
      Table statistics collection enabled (the limit is 1000, the actual table count is 500).
      
      MySQL Service added.
      Service ID  : /service_id/1
      Service name: mysql-1
      
      Table statistics collection enabled (the table count limit is not set).
      
      MySQL Service added.
      Service ID  : /service_id/1
      Service name: mysql-1
      
      Table statistics collection enabled (the limit is 1000, the actual table count is unknown).
      
      MySQL Service added.
      Service ID  : /service_id/1
      Service name: mysql-1
      
      Table statistics collection disabled (the limit is 1000, the actual table count is 2000).
      
      MySQL Service added.
      Service ID  : /service_id/1
      Service name: mysql-1
      
      Table statistics collection disabled (always).
      

      Attachments

        Activity

          People

            Unassigned Unassigned
            alexander.blinkov Alexander Blinkov (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - Not Specified
                Not Specified
                Logged:
                Time Spent - 3 hours, 10 minutes
                3h 10m

                Smart Checklist