Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-5926

Expose PMM-agent version in pmm-admin status command

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.7.0
    • Component/s: PMM Agent
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Platform Sprint 16, Platform Sprint 17
    • Needs Review:
      Yes
    • Needs QA:
      Yes
    • Needs Doc:
      Yes

      Description

      We should expose pmm-agent version in pmm-agent local API and show it in `pmm-admin status` command.
      We need to receive from pmm-agent because in 1% of all cases pmm-agent version can be different from pmm-admin version.

      What's expected

       # pmm-admin status
      Agent ID: /agent_id/c2a55ac6-a12f-4172-8850-4101237a4236
      Node ID : /node_id/29b2cc24-3b90-4892-8d7e-4b44258d9309
      PMM Server:
       URL : https://x.x.x.x:443/
       Version: 2.5.0
      PMM Client:
       Connected : true
       Time drift: 2.152715ms
       Latency : 465.658µs
       pmm-admin version: 2.5.0
       pmm-agent version: 2.5.0
      Agents:
       /agent_id/aeb42475-486c-4f48-a906-9546fc7859e8 mysql_slowlog_agent Running

      How it looks now

       # pmm-admin status
      Agent ID: /agent_id/c2a55ac6-a12f-4172-8850-4101237a4236
      Node ID : /node_id/29b2cc24-3b90-4892-8d7e-4b44258d9309
      PMM Server:
       URL : https://x.x.x.x:443/
       Version: 2.5.0
      PMM Client:
       Connected : true
       Time drift: 2.152715ms
       Latency : 465.658µs
       pmm-admin version: 2.5.0
      Agents:
       /agent_id/aeb42475-486c-4f48-a906-9546fc7859e8 mysql_slowlog_agent Running

       

      DOC: update pmm-admin status output example  

       

      Files which can be affected:

      https://github.com/percona/pmm/blob/PMM-2.0/api/agentlocalpb/agentlocal.proto

      https://github.com/percona/pmm-agent/blob/master/agentlocal/agent_local.go

      https://github.com/percona/pmm-admin/blob/master/agentlocal/agentlocal.go

      https://github.com/percona/pmm-admin/blob/master/commands/status.go

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              nurlan.moldomurov Nurlan Moldomurov
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 2 hours, 30 minutes
                  2h 30m

                    Smart Checklist