Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-636

Restart of pmm-admin after client IP change should complete quickly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Low
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: PMM Client, PMM Server
    • Labels:

      Description

      I had server running PMM set up with DHCP which was assigned different IP upon reboot. This breaks pmm-client (which is somewhat expected) but also makes restart to be very slow:

      root@rocky:~# time pmm-admin restart --all
       OK, 3 services are restarted.
      
      real 1m56.070s
       user 0m0.016s
       sys 0m0.024s
      

      This is painful in shutdown updates etc. Perhaps some timeouts can be substantially lowered We also need to consider what is expected behavior in such case - we can have for example pmm-server on the start to re-negotiate its IP.

      Expectations

      1. Client restart should have a reasonable timeout value
      2. Client should compare what's in Consul vs currentĀ IP during check-network execution
      3. Client should automatically update Consul with new IP address
        pmm-admin config --bind-address <IP> --client-address <IP>
      1. Restart should either complete or generate error in under 10s
      2. Restart that times out should generate useful error message
        Client restart timed out waiting for:
        Network timeout: Could not reach PMM Server at <ip>:<port>

        Smart Checklist

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  pz Peter Zaitsev
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated: