XMLWordPrintable

    Details

    • Type: Admin & Maintenance Task
    • Status: Done
    • Priority: High
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 2.11.0
    • Component/s: PMM ManageD, PMM Server
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Platform Sprint 26, Platform Sprint 27
    • Needs Review:
      Yes
    • Needs QA:
      Yes

      Description

      SaaS recently updated to using protobuf 1.4 everywhere, which is a major update despite the minor version change: https://blog.golang.org/protobuf-apiv2 percona-platform/platform and saas repos now contain files generated by 1.4, and the current version of pmm-managed can't use them.

      percona/pmm should be updated to use 1.4, and then all dependants should be updated too.

      Steps:
      1) Update requred dependencies

      github.com/golang/protobuf v1.4.2
      github.com/fullstorydev/grpcurl v1.7.

      2) Add full package name to go_package variable in each proto file.  (Solution described here: https://github.com/uber/prototool/issues/549)

      - option go_package = "retrievalv1";
      + option go_package = "check/retrieval;retrievalv1";

      3) Disable this linters in prototool.yaml

      FILE_OPTIONS_EQUAL_GO_PACKAGE_V2_SUFFIX
      FILE_OPTIONS_GO_PACKAGE_NOT_LONG_FORM
      

      4) Check that all protobuf version mentions are updated across the project (In Makefiles, Dockerfiles, CI, etc.)

      5) Regenerate APIs

      6) Update pmm repository everywhere

      7) Remove pmm-managed hack from https://github.com/percona/pmm-managed/pull/461
       

      This PR can be used as a reference:
      https://github.com/percona-platform/platform/pull/128/files

       

      How to test:

      Test connection between components.

      • Old pmm-agent with new pmm-managed
      • new pmm-agent with old pmm-managed
      • pmm-admin <-> pmm-agent
      • pmm-admin <-> pmm-managed

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              andrii.skomorokhov Andrii Skomorokhov
              Reporter:
              alexey.palazhchenko Alexey Palazhchenko (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 1 day, 2 hours
                  1d 2h

                    Smart Checklist