Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-6642

Align pg_stat_monitor buckets

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Sprint:
      Platform Sprint 26, Platform Sprint 27
    • Needs Review:
      Yes
    • Needs QA:
      Yes

      Description

      Based on discussion with Ibrar it looks like we can have multiple queries with the same id, but in different buckets.
      So we should handle each bucket separately and don't count them twice

       To not count them twice we can align our collects with bucket start times.

      And also please address these comments in https://github.com/percona/pmm-agent/pull/183

      Please move the second half to a separate case with a different logging line (but the same logic) and test with debug logging

      [https://github.com/percona/pmm-agent/pull/183#discussion_r486850349
      ]

      How to test it:

      1. Enable pg_stat_monitor extension for PostgreSQL server.
      2. Add PG with pg_stat_monitor to pmm.
      3. Run some SQL queries.
      4. Wait for metrics more time than `pg_stat_monitor.pgsm_bucket_time` value.
      5. Check that query count is not more than you've run.

        Attachments

          Activity

            People

            Assignee:
            jiri.ctvrtka Jiří Čtvrtka
            Reporter:
            alexander.blinkov Alexander Blinkov (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Smart Checklist