Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-6896

Data Retention Value not being set with VM

Details

    • Bug
    • Status: Done
    • Medium
    • Resolution: Fixed
    • 2.12.0
    • 2.12.0
    • VictoriaMetrics
    • Yes
    • Platform Sprint 29 (2.12+a2), Platform Sprint 30 (2.12+b1)
    • Yes
    • Yes

    Description

      When users on an older version of PMM or even on a fresh install(dev-latest), provide a custom Data retention period, we are not passing the same to VM. 

      Steps to recreate:

      1) Install PMM 2.11.1, set Data_Retention  to 1 day or 2 days or x days. 
      2) Check PMM-Setting if the Data Retention value is being shown correctly. 
      3) Enable testing Repo and Upgrade to Latest PMM Dev version, after Upgrade
      4) Download PMM-Server logs, check the victoriametrics.ini file, see the value being passed to dataRetention. 

      5) Get in pmm-server docker container, check the output for `ps aux | grep victoria` see the actual parameter passed, it is not the same as provided by user. 

      This issue is with both Upgraded instances as well as new Instances. 

      Providing data retention in Days to VM is supported by VM v1.45+ and it can be found on the release notes https://github.com/VictoriaMetrics/VictoriaMetrics/blob/master/CHANGELOG.md#v1450  and https://github.com/VictoriaMetrics/VictoriaMetrics#retention 

      Expected Behaviour: 

      Users Data Retention Period or Default must be used, and should not change for upgraded as well new instances. 

      Attachments

        Activity

          People

            nurlan.moldomurov Nurlan Moldomurov
            puneet.kala Puneet Kala
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - Not Specified
                Not Specified
                Logged:
                Time Spent - 5 hours
                5h

                Smart Checklist