Uploaded image for project: 'Percona Monitoring and Management'
  1. Percona Monitoring and Management
  2. PMM-8259

Better clarification of error messages in `pmm-admin` when PMM server can't be unregistered

Details

    • Improvement
    • Status: Done
    • Medium
    • Resolution: Done
    • None
    • 2.25.0
    • PMM Admin
    • 0.5
    • Yes
    • Yes
    • [obsolete] C/S Core

    Description

      There are some cases where pmm-admin error message doesn't make much sense. For example here the error is not due to incorrect username/password but because the operation is forbidden by PMM Server so the error should be more generic.

      [ec2-user@ip-10-178-2-29 ~]$ pmm-admin unregister --force --node-name=pmm-server
      PMM Server node can't be removed.. Please check username and password.
      

      The first half of the error message is from pmm-managed, the second part is from pmm-admin in response to the 403 by pmm-managed.

      https://github.com/percona/pmm-admin/blob/master/main.go#L179-L197

      More info

      https://perconacorp.slack.com/archives/G2HEW592P/p1623398121177900 

       

      Attachments

        Activity

          People

            shashank.sinha Shashank Sinha (Inactive)
            beata.handzelova1 Beata Handzelova (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Smart Checklist