Uploaded image for project: 'Percona Server for MySQL'
  1. Percona Server for MySQL
  2. PS-1223

LP #890404: valgrind warning from innodb_fake_changes patch

    Details

    • Type: Bug
    • Status: Done
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      **Reported in Launchpad by Mark Callaghan last update 16-11-2012 05:53:16

      The problem occurs because btr_cur_upd_lock_and_undo does not initialize "roll_ptr" when trx->fake_changes is true, but btr_cur_pessimistic_update uses roll_ptr after calling btr_cur_update_lock_and_undo when trx->fake_changes is true via:
      if (!(flags & BTR_KEEP_SYS_FLAG)) {
      row_upd_index_entry_sys_field(new_entry, index, DATA_ROLL_PTR,
      roll_ptr);

      I am new to this code and think that adding '& !trx->fake_changes' to the 'if' block above might fix the problem

        Smart Checklist

          Attachments

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                lpjirasync lpjirasync (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: