Uploaded image for project: 'Percona Server for MySQL'
  1. Percona Server for MySQL
  2. PS-1447

LP #1250148: log_block_checksum_is_ok_or_old_format() uses page not log block checksum algorithm

Details

    Description

      **Reported in Launchpad by Laurynas Biveinis last update 12-11-2013 17:37:27

      log_block_checksum_is_ok_or_old_format uses srv_checksum_algorithm instead of srv_log_checksum_algorithm everywhere except the 1st use:

      log_block_checksum_is_ok_or_old_format(...)
      {
      if (UNIV_LIKELY(srv_log_checksum_algorithm ==
      SRV_CHECKSUM_ALGORITHM_NONE ||
      log_block_calc_checksum(block) == block_checksum)) {
      ...
      if (srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_STRICT_CRC32 ||
      srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_STRICT_INNODB ||
      srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_STRICT_NONE) {
      ...
      ut_ad(srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_CRC32 ||
      srv_checksum_algorithm == SRV_CHECKSUM_ALGORITHM_INNODB);

      Effectively meaning that this function will diagnose log block algorithms mismatch using the data page algorithm instead of log block algorithm.

      Attachments

        Activity

          People

            Unassigned Unassigned
            lpjirasync lpjirasync (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Smart Checklist