Uploaded image for project: 'Percona Server'
  1. Percona Server
  2. PS-2545

LP #610525: compiler warnings for 5.1.47-rel11.2

    Details

    • Type: Bug
    • Status: Done
    • Priority: Low
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      **Reported in Launchpad by Mark Callaghan last update 27-09-2010 10:52:17

      I built 5.1.470-rel11.2 from source. The build server is centos 5.2 using gcc 4.1.2

      Configured it with:
      ./configure --enable-thread-safe-client --with-plugins=partition,csv,blackhole,myisam,heap,innodb_plugin --without-plugin-innobase --with-fast-mutexes --with-extra-charsets=all --with-debug C_EXTRA_FLAGS="-fno-omit-frame-pointer -fno-strict-aliasing -DHAVE_purify -Wall"

      There are many compiler warnings in storage/innodb_plugin. I think all of this are new from Percona. I don't think that base InnoDB has these. Some of these are minor. Others are not.

      btr/btr0btr.c:2928: warning: null argument where non-null required (argument 1)
      btr/btr0cur.c:1834: warning: null argument where non-null required (argument 2)
      btr/btr0cur.c:1853: warning: null argument where non-null required (argument 1)
      btr/btr0cur.c:1960: warning: null argument where non-null required (argument 1)
      btr/btr0cur.c:3415: warning: unused variable j
      buf/buf0buf.c:3526: warning: format %lu expects type long unsigned int, but argument 3 has type unsigned int
      buf/buf0buf.c:81: warning: format %lu expects type long unsigned int, but argument 4 has type int
      buf/buf0buf.c:82: warning: comparison is always false due to limited range of data type
      buf/buf0buf.c:83: warning: format %lu expects type long unsigned int, but argument 4 has type int
      fil/fil0fil.c:3125: warning: pointer targets in passing argument 2 of dict_table_get_index_on_name differ in signedness
      fil/fil0fil.c:3149: warning: unknown conversion type character : in format
      fil/fil0fil.c:3239: warning: implicit declaration of function row_get_trx_id_offset
      fil/fil0fil.c:3326: warning: implicit declaration of function que_eval_sql
      fsp/fsp0fsp.c:661:1: warning: multi-line comment
      handler/ha_innodb.cc:2047: warning: comparison between signed and unsigned integer expressions
      handler/i_s.cc:3040: warning: unused variable cs
      ibuf/ibuf0ibuf.c:792: warning: null argument where non-null required (argument 1)
      ibuf/ibuf0ibuf.c:967: warning: null argument where non-null required (argument 1)
      ./include/mtr0log.ic:206: warning: comparison between signed and unsigned integer expressions
      log/log0recv.c:3328: warning: unused variable file
      os/os0file.c:4188: warning: pointer targets in assignment differ in signedness
      ../../sql/handler.h:1125: warning: ulonglong handler::rows_read
      ../../sql/handler.h:1156: warning: handler::auto_inc_intervals_count will be initialized after
      ../../sql/handler.h:1158: warning: when initialized here
      srv/srv0srv.c:1121: warning: value computed is not used
      srv/srv0srv.c:1151: warning: value computed is not used
      srv/srv0srv.c:1358: warning: value computed is not used
      srv/srv0srv.c:1851: warning: unused variable io_counter_subtotal
      sync/sync0sync.c:437: warning: unused variable ptr
      trx/trx0sys.c:1146: warning: unused variable sys_header
      trx/trx0sys.c:1147: warning: unused variable slot_no
      trx/trx0sys.c:1150: warning: unused variable page_no
      trx/trx0sys.c:1151: warning: unused variable i

      And these are warnings from the sql directory that I think are new. I will guess that some originated in the Google patch.

      sql_show.cc:2416: warning: int aggregate_user_stats(HASH*, HASH*) defined but not used
      sql_show.cc:2428: warning: comparison between signed and unsigned integer expressions
      sql_show.cc:2479: warning: format %d expects type int, but argument 2 has type ulong
      sql_show.cc:2479: warning: format %d expects type int, but argument 3 has type ulong
      sql_show.cc:2499: warning: comparison between signed and unsigned integer expressions
      sql_show.cc:2535: warning: comparison between signed and unsigned integer expressions
      sql_show.cc:2680: warning: comparison between signed and unsigned integer expressions
      sql_show.cc:2723: warning: comparison between signed and unsigned integer expressions
      sql_table.cc:1881: warning: alias may be used uninitialized in this function
      sql_table.cc:1882: warning: path_length may be used uninitialized in this function

        Attachments

          Expenses

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                lpjirasync lpjirasync (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: