Uploaded image for project: 'Percona Server'
  1. Percona Server
  2. PS-275

Deprecate and obsolete max_binlog_files with binlog_space_limit

    XMLWordPrintable

    Details

    • Type: New Feature
    • Status: Done
    • Priority: High
    • Resolution: Done
    • Affects Version/s: 5.5, 5.6, 5.7, 8.0
    • Fix Version/s: 8.0.12-2rc1, 5.7.23-23
    • Component/s: None
    • Labels:
      None

      Description

      The max_binlog_files feature wasn't thought through well enough and has
      a couple of important drawbacks:

      • it is inconsistent with a similar variable for relay logs
        (--relay-log-space-limit). It's reasonable to implement a similar
        variable for binary logs with the same semantics.
      • max_binlog_files is hard (and sometimes dangerous) to use in practice,
        because server restarts and FLUSH LOGS make the server start new
        files, rendering the variable useless from the user perspective.

      We should deprecate max_binlog_files and introduce max_binlog_space
      (binlog_space_limit?) that would obsolete max_binlog_files.

      5.7 will have an upgrade path from that (both max_binlog_files and binlog_space_limit)
      8.0 will have only binlog_space_limit

        Smart Checklist

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  przemyslaw.skibinski Przemyslaw Skibinski
                  Reporter:
                  laurynas.biveinis Laurynas Biveinis
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 4 days, 6 hours, 34 minutes
                    4d 6h 34m