Uploaded image for project: 'Percona Server'
  1. Percona Server
  2. PS-3955

Broken sync between innodb_kill_idle_transaction and kill_idle_transaction system variables

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: 5.6, Not 5.5, Not 5.7
    • Fix Version/s: 5.6.40-84.0
    • Component/s: None

      Description

      This shows up as a sys_vars.kill_idle_transaction_basic failure on the current 5.6 trunk:

      sys_vars.kill_idle_transaction_basic     w1 [ fail ]
              Test ended at 2018-03-13 17:34:12
      
      CURRENT_TEST: sys_vars.kill_idle_transaction_basic
      --- /mnt/workspace/percona-server-5.6-trunk/BUILD_TYPE/debug/Host/min-artful-x64/mysql-test/suite/sys_vars/r/kill_idle_transaction_basic.result	2018-03-13 19:14:56.164499180 +0300
      +++ /mnt/workspace/percona-server-5.6-trunk/BUILD_TYPE/debug/Host/min-artful-x64/build/mysql-test/var/1/log/kill_idle_transaction_basic.reject	2018-03-13 20:34:12.641170429 +0300
      @@ -44,7 +44,7 @@
       KILL_IDLE_TRANSACTION	12345
       SELECT @@innodb_kill_idle_transaction;
       @@innodb_kill_idle_transaction
      -12345
      +0
       SET GLOBAL kill_idle_transaction= 4294967295;
       Warnings:
       Warning	1292	Truncated incorrect kill_idle_transaction value: '4294967295'
      @@ -56,7 +56,7 @@
       KILL_IDLE_TRANSACTION	31536000
       SELECT @@innodb_kill_idle_transaction;
       @@innodb_kill_idle_transaction
      -31536000
      +0
       SET GLOBAL kill_idle_transaction= 31536000;
       SHOW GLOBAL VARIABLES LIKE 'kill_idle_transaction';
       Variable_name	Value
      @@ -66,5 +66,5 @@
       KILL_IDLE_TRANSACTION	31536000
       SELECT @@innodb_kill_idle_transaction;
       @@innodb_kill_idle_transaction
      -31536000
      +0
       SET GLOBAL kill_idle_transaction= @saved_kill_idle_transaction;
      
      mysqltest: Result content mismatch
      
      safe_process[17024]: Child process: 17025, exit: 1
      

      It started failing between c135bbd9970557a22119a303724e5c37fb070c58 and c3d76925c98207384194de226dfc4111654b2b422b42:

      commit c3d76925c98207384194de226dfc4111654b2b42
      Merge: c135bbd9970 fdb3aa25860
      Author: Przemyslaw Skibinski <przemyslaw.skibinski@percona.com>
      Date:   Tue Mar 13 12:12:30 2018 +0100
      
          Merge pull request #2223 from inikep/ps5.6-PS-3883
          
          PS-3883 (5.6): Test more conditional builds with Travis
      
      commit fdb3aa258607d78db77bea3a1b61c1dbf6a5af7e
      Author: przemyslaw.skibinski@percona.com <przemyslaw.skibinski@percona.com>
      Date:   Fri Mar 9 18:01:28 2018 +0100
      
          PS-3883: Test more conditional builds with Travis
          
          Test more options with builds that use `INVERTED=ON`:
          `-DWITH_EMBEDDED_SERVER=OFF`
          `-DWITH_QUERY_RESPONSE_TIME=ON`
          Add `-DWITH_XXX_STORAGE_ENGINE=YYY` to INVERTED
      

      It is likely caused by

      diff --git a/sql/sys_vars.cc b/sql/sys_vars.cc
      index 466235dc0ad..281c0a49eb9 100644
      --- a/sql/sys_vars.cc
      +++ b/sql/sys_vars.cc
      @@ -2140,12 +2140,16 @@ static Sys_var_ulong Sys_net_write_timeout(
              ON_UPDATE(fix_net_write_timeout));
       
       // Sync kill_idle_transaction and innodb_kill_idle_transaction values
      +#ifdef WITH_INNOBASE_STORAGE_ENGINE
       extern long srv_kill_idle_transaction;
      +#endif
       
       static bool fix_kill_idle_transaction(sys_var *self, THD *thd,
                                             enum_var_type type)
       {
      +#ifdef WITH_INNOBASE_STORAGE_ENGINE
         srv_kill_idle_transaction= kill_idle_transaction_timeout;
      +#endif
         return false;
       }
      

        Smart Checklist

          Attachments

            Activity

              People

              • Assignee:
                przemyslaw.skibinski Przemyslaw Skibinski
                Reporter:
                laurynas.biveinis Laurynas Biveinis
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 hours, 15 minutes
                  2h 15m