Uploaded image for project: 'Percona Server'
  1. Percona Server
  2. PS-4160

myrocks depends on minor const correctness bits in the common server code

    XMLWordPrintable

    Details

    • Type: Admin & Maintenance Task
    • Status: Done
    • Priority: Medium
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 5.7.18-14
    • Component/s: MyRocks

      Description

      webscale/facebook has some improved const-ness in the common server code that myrocks depends on. The fix is to either take the server improvements, remove and unwind a lot of const correctness in myrocks, or const_cast at touchpoints.

      https://github.com/facebook/mysql-5.6/commit/0a547cb61ace9a73feb677fec662432c97371dc0 : Write unpack info only up to key prefix length

      https://blueprints.launchpad.net/percona-server/+spec/myrocks-const-correct-5.6
      https://blueprints.launchpad.net/percona-server/+spec/myrocks-const-correct-5.7

        Smart Checklist

          Attachments

            Activity

              People

              • Assignee:
                george.lorch George Lorch
                Reporter:
                george.lorch George Lorch
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: