Uploaded image for project: 'Percona Server'
  1. Percona Server
  2. PS-4209

Make default cf compression option to be LZ4

    Details

    • Type: Bug
    • Status: Done
    • Priority: Low
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.7.20-18
    • Component/s: MyRocks
    • Labels:
      None

      Description

       

      Vadim Tkachenko @george.lorch can we enable LZ4 compression as default ?
      [7:30 PM] 
       George Lorch Hmm
      [7:30 PM] 
       Vadim Tkachenko that is if even nothing specified, the files get compressed with LZ4 ?
      [7:31 PM] 
       George Lorch Probably can just not sure exactly how to do it as compression goes in as column family options, which is a really bizarre hackish thing
      [7:31 PM] 
       Vadim Tkachenko so set default properly for column family as LZ4 compressed
      [7:31 PM] 
       George Lorch but off the top of my head I think we can maybe use default_cf_options to specify the 'default' compression for the 'default' column family
      [7:32 PM] 
       'new' column families would need to explicitly specify
      [7:32 PM] 
       Vadim Tkachenko that's fine
      [7:32 PM] 
       George Lorch as that is more of a rocksdb thing and not myrocks, myrocks itself doesn't parse or understand rocksdb column family options
      [7:33 PM] 
       but I think that will work, I'll have to poke at it a bit just to be sure
      [7:33 PM] 
       Vadim Tkachenko yes, please take a look!
      

       

       

      [1:29 PM] 
      George Lorch hey @vadimtk so my idea of providing a default value for rocksdb_default_cf_options to set the compression on the 'default' column family seem will work fine. RocksDB team recommends though that you use LZ4 for all levels except the bottom where it should be zstd. I think we should make this the default instead of just LZ4 all the way down. Any objections?
      
      
      [1:29 PM] 
      Vadim Tkachenko LZ4 default on all levels is fine with me
      
      
      [1:30 PM] 
      if someone wants ZSTD - s/he can adjust options
      
      
      [1:30 PM] 
      George Lorch OK, no problem, it's easy enough.
      

        Smart Checklist

          Attachments

            Activity

              People

              • Assignee:
                george.lorch George Lorch
                Reporter:
                george.lorch George Lorch
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: