Uploaded image for project: 'Percona Server'
  1. Percona Server
  2. PS-4370

'Fix' tokub conditional compilation dependent on version id starting in 5.7

    XMLWordPrintable

    Details

    • Type: Epic
    • Status: Done
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.7.21-21
    • Component/s: TokuDB
    • Labels:
      None

      Description

      There is much code in the TokuDB tree that is MYSQL_VERSION_ID dependent that should be stripped and leave the correct code in place for the correct version branch. It clutters the code and makes cross version-branch diffs difficult. Only code supported by the version branch should exist within that branch. This is not to suggest removing the numerous feature opt in/out that are set up by the version id detection, just to eliminate various places where function signatures and such are #if MYSQL_VERSION_ID ... around with one signature for each version, etc... Also to remove all of the various MYSQL_VERSION_ID #ifs except the specific version that the branch is from the hatoku_defines.h

        Smart Checklist

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  george.lorch George Lorch
                  Reporter:
                  george.lorch George Lorch
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 6 hours, 55 minutes
                    6h 55m