Uploaded image for project: 'Percona Server'
  1. Percona Server
  2. PS-4488

`-Werror` is always disabled for `innodb_memcached`

    Details

    • Type: Improvement
    • Status: Done
    • Priority: Low
    • Resolution: Fixed
    • Affects Version/s: 5.7.21-21, 5.6.39-83.1
    • Fix Version/s: 5.7.22-22, 5.6.41-84.1
    • Component/s: None
    • Labels:
      None

      Description

      `-Werror` is removed for `innodb_memcached` at:
      https://github.com/percona/percona-server/blob/5.7/plugin/innodb_memcached/daemon_memcached/CMakeLists.txt#L33-L38

      It was introduced in https://github.com/percona/percona-server/commit/7396e82fcc2d4a927706629d37da29d9e8416f67 what says:

      So instead of turning off these options thoroughly, I just turn off
      -Werror for innodb memcached plugin. When we introduce new files
      with or without new warnings in the future, we don't have to modify these
      CMakeLists.txt again.
      

      We should fix warnings and enable `-Werror`.

        Smart Checklist

          Attachments

            Activity

              People

              • Assignee:
                przemyslaw.skibinski Przemyslaw Skibinski
                Reporter:
                przemyslaw.skibinski Przemyslaw Skibinski
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 2 days, 1 hour, 55 minutes
                  2d 1h 55m