Uploaded image for project: 'Percona Server for MySQL'
  1. Percona Server for MySQL
  2. PS-4530

Add documentation that ps-admin removes jemalloc and THP settings on TokuDB uninstall

    XMLWordPrintable

    Details

      Description

      This is done regardless of what were the settings before TokuDB installation and if user want to keep them or not.

      Emails:

       DBennett:
       Is this by design? 
       
       One (easiest) option would be to leave jemalloc and THP as is and provide options allowing the user to reconfigure those separately. We could also provide messaging on TokuDB deinstallation letting the user know about the current state of these settings and what to do next.
       
       Another, more involved solution, would be to capture the previous state of the system in metadata stored in my.cnf comments and then reinstate the previous configuration on uninstall.
       
       On Sat, Jun 16, 2018 at 3:55 PM, Peter Zaitsev <pz@percona.com> wrote:
       Hi,
       
       I noticed TokuDB de-installation seems to remove jemalloc ENABLES huge pages etc
       
       Is this ALWAYS done or are we restoring it to the previous settings which were done before the run ?
       
       root@skullnuc:/var/lib/mysql# ps-admin --disable tokudb
       ps-admin: option '--disable' is ambiguous; possibilities: '--disable-tokudb' '--disable-mysqlx' '--disable-pam-compat' '--disable-pam' '--disable-audit' '--disable-qrt' '--disable-rocksdb' '--disable-tokubackup'
       root@skullnuc:/var/lib/mysql# ps-admin --disable-tokudb
       Checking transparent huge pages status on the system...
       INFO: Transparent huge pages are currently disabled on the system.
       
       Checking if THP_SETTING variable is set to never or madvise in /etc/default/mysql...
       INFO: Variable THP_SETTING is set in /etc/default/mysql.
       
       Checking if LD_PRELOAD variable is set for libjemalloc.so.1 in /etc/default/mysql...
       INFO: Variable LD_PRELOAD for libjemalloc.so.1 is set in /etc/default/mysql.
       
       Checking if LD_PRELOAD variable is set for libHotBackup.so in /etc/default/mysql...
       INFO: Variable LD_PRELOAD for libHotBackup.so is not set in /etc/default/mysql.
       
       Checking TokuDB engine plugin status...
       INFO: TokuDB engine plugin is installed.
       
       Checking TokuBackup plugin status...
       INFO: TokuBackup plugin is not installed.
       
       Removing THP_SETTING variable from /etc/default/mysql
       INFO: Successfully removed THP_SETTING variable from /etc/default/mysql
       
       Removing LD_PRELOAD option from /etc/default/mysql
       INFO: Successfully removed LD_PRELOAD option for libjemalloc.so.1 and libHotBackup.so from /etc/default/mysql
       
       Uninstalling TokuDB engine plugin...
       INFO: Successfully uninstalled TokuDB engine plugin.
      

        Attachments

          Activity

            People

            Assignee:
            patrick.birch Patrick Birch
            Reporter:
            tomislav.plavcic@percona.com Tomislav Plavcic
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - Not Specified
                Not Specified
                Logged:
                Time Spent - 2 hours, 30 minutes
                2h 30m

                  Smart Checklist