Uploaded image for project: 'Percona Server for MySQL'
  1. Percona Server for MySQL
  2. PS-4757

Remove CHECK_IF_CURL_DEPENDS_ON_RTMP to build keyring_vault for unconditional test

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: 5.7.22-22
    • Fix Version/s: 5.7.30-33, 8.0.20-11
    • Component/s: None
    • Labels:
      None

      Description

      On Ubuntu Bionic (where CURL library depends on RTMP library) keyring_vault unit tests can be build and run without any issues (all clean including ASan and Valgrind). However, by default they are disabled by CHECK_IF_CURL_DEPENDS_ON_RTMP CMake macro.

      To test, just disable CHECK_IF_CURL_DEPENDS_ON_RTMP() calls in

      plugin/keyring_vault/keyring_vault-test/CMakeLists.txt
      unittest/gunit/keyring_vault/CMakeLists.txt
      

      build and run

      ./mysql-test/mtr --debug-server main.1st --unit-tests
      

      Consider eliminating this macro and build keyring_vault unit tests unconditionally.

        Smart Checklist

          Attachments

            Activity

              People

              Assignee:
              yura.sorokin Yura Sorokin
              Reporter:
              yura.sorokin Yura Sorokin
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 1 day, 15 minutes
                  1d 15m