Uploaded image for project: 'Percona Server for MySQL'
  1. Percona Server for MySQL
  2. PS-5075

TokuDB has independent unconditional check for valgrind

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: On Hold
    • Priority: Medium
    • Resolution: Unresolved
    • Affects Version/s: 5.7.x, Not 5.5.x
    • Fix Version/s: None
    • Component/s: TokuDB
    • Labels:
      None

      Description

      TokuDB (TokuFT) in 5.7 and maybe in other versions should check for VALGRIND_FOUND cmake variable and run autonomous check only if variable is empty.
      now it leads to problem if valgrind is installed in another location (from centos devtoolset).

      patch may look like following:

      diff --git a/cmake_modules/FindValgrind.cmake b/cmake_modules/FindValgrind.cmake
      index 73841723c..77bd21449 100644
      --- a/cmake_modules/FindValgrind.cmake
      +++ b/cmake_modules/FindValgrind.cmake
      @@ -7,7 +7,7 @@
       #
       # If you have valgrind installed in a non-standard place, you can define
       # VALGRIND_PREFIX to tell cmake where it is.
      -
      +IF(NOT VALGRIND_FOUND)
       find_path(VALGRIND_INCLUDE_DIR valgrind/memcheck.h)
       find_program(VALGRIND_PROGRAM NAMES valgrind)
      @@ -16,3 +16,4 @@ find_package_handle_standard_args(Valgrind DEFAULT_MSG
           VALGRIND_PROGRAM)
       mark_as_advanced(VALGRIND_INCLUDE_DIR VALGRIND_PROGRAM)
      +ENDIF(NOT VALGRIND_FOUND)
      

      file to edit: storage/tokudb/PerconaFT/cmake_modules/FindValgrind.cmake
      `VALGRIND_FOUND` is set globally in `./configure.cmake:656:IF(WITH_VALGRIND)`

        Smart Checklist

          Attachments

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              alexey.bychko Alexey Bychko (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 1 hour
                  1h