Uploaded image for project: 'Percona Server'
  1. Percona Server
  2. PS-508

LP #878022: Atomic access issues with vars in response_time_distribution.patch

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      **Reported in Launchpad by Laurynas Biveinis last update 03-02-2014 10:36:51

      Even with the bug 803865 fixed, couple of issues with atomic access in the response_time_distribution.patch remain:
      1) The i386 CAS inline asm is missing "memory" and "volatile", see comments #10 and #11 at bug 803865. It is very likely that this bug is benign for now, still must be fixed.
      2) The time_collector::m_count and m_total variables are declared volatile, which is wrong. Volatility has nothing to do with atomicity, volatile variables are those with unpredictable accesses. Here the accesses are very predictable.

        Smart Checklist

          Attachments

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                lpjirasync lpjirasync (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: