Details
-
Bug
-
Status: Done
-
Medium
-
Resolution: Fixed
-
5.7.x, 8.0.x
-
None
Description
A regression of PS-4933 fix:
190412 1:43:21 [ 59%] main.slow_log_extra w4 [ fail ]
Test ended at 2019-04-12 01:43:21
CURRENT_TEST: main.slow_log_extra
--- /tmp/results/PS/mysql-test/r/slow_log_extra.result 2019-04-12 02:53:05.000000000 +0300
+++ /tmp/results/PS/mysql-test/var/4/log/slow_log_extra.reject 2019-04-12 04:43:21.520910909 +0300
@@ -79,5 +79,5 @@
Rows_sent: 8 Rows_examined: 8 Thread_id: 0 Errno: 0 Killed: 0 Bytes_received: 0 Bytes_sent: 106 Read_first: 1 Read_last: 0 Read_key: 1 Read_next: 0 Read_prev: 0 Read_rnd: 0 Read_rnd_next: 9 Sort_merge_passes: 0 Sort_range_count: 0 Sort_rows: 0 Sort_scan_count: 0 Created_tmp_disk_tables: 0 Created_tmp_tables: 0
Rows_sent: 8 Rows_examined: 8 Thread_id: 0 Errno: 0 Killed: 0 Bytes_received: 0 Bytes_sent: 106 Read_first: 0 Read_last: 0 Read_key: 0 Read_next: 0 Read_prev: 0 Read_rnd: 0 Read_rnd_next: 9 Sort_merge_passes: 0 Sort_range_count: 0 Sort_rows: 0 Sort_scan_count: 0 Created_tmp_disk_tables: 0 Created_tmp_tables: 0
Rows_sent: 8 Rows_examined: 8 Thread_id: 0 Errno: 0 Killed: 0 Bytes_received: 0 Bytes_sent: 106 Read_first: 0 Read_last: 0 Read_key: 0 Read_next: 0 Read_prev: 0 Read_rnd: 0 Read_rnd_next: 9 Sort_merge_passes: 0 Sort_range_count: 0 Sort_rows: 0 Sort_scan_count: 0 Created_tmp_disk_tables: 0 Created_tmp_tables: 0
-Rows_sent: 0 Rows_examined: 0 Thread_id: 0 Errno: 0 Killed: 0 Bytes_received: 0 Bytes_sent: 0 Read_first: 0 Read_last: 0 Read_key: 0 Read_next: 0 Read_prev: 0 Read_rnd: 0 Read_rnd_next: 0 Sort_merge_passes: 0 Sort_range_count: 0 Sort_rows: 0 Sort_scan_count: 0 Created_tmp_disk_tables: 0 Created_tmp_tables: 0
+Rows_sent: 0 Rows_examined: 8 Thread_id: 0 Errno: 0 Killed: 0 Bytes_received: 0 Bytes_sent: 0 Read_first: 0 Read_last: 0 Read_key: 0 Read_next: 0 Read_prev: 0 Read_rnd: 0 Read_rnd_next: 0 Sort_merge_passes: 0 Sort_range_count: 0 Sort_rows: 0 Sort_scan_count: 0 Created_tmp_disk_tables: 0 Created_tmp_tables: 0
SET @@global.slow_query_log_file=@save_sqlf;
mysqltest: Result content mismatch
The test failure happens because COM_QUIT is logged with Rows_examined: 8, because they were not cleared from the last command. This happened because PS-4933 erroneously removed clear_slow_extended() call from dispatch_command, considering that the call from THD::reset_for_next_command is enough. This is not the case for all COM_* though.
Attachments
Issue Links
- is caused by
-
-
- Done
-
