Uploaded image for project: 'Percona Server for MySQL'
  1. Percona Server for MySQL
  2. PS-5686

innodb_redo_log_encrypt must throw an error while setting invalid values

    XMLWordPrintable

    Details

      Description

      It is noticed while testing PS-4556, that below queries are actually executable

      set global innodb_redo_log_encrypt =2;
      set global innodb_redo_log_encrypt =3;
      set global innodb_redo_log_encrypt =true;

      However, as per functionality the only supported values must be
      ON, OFF, master_key, keyring_key

      Values 1,2,3,true,on all sets the value to "on"

      Ideally, setting these values make no sense and must be restricted.

       

      Second observation is:
      mysql> show global variables like 'innodb%encrypt%';
      ---------------------------------------+

      Variable_name Value

      ---------------------------------------+

      innodb_default_encryption_key_id 0
      innodb_encrypt_online_alter_logs OFF
      innodb_encrypt_tables OFF
      innodb_encryption_rotate_key_age 1
      innodb_encryption_rotation_iops 100
      innodb_encryption_threads 0
      innodb_parallel_dblwr_encrypt OFF
      innodb_redo_log_encrypt off
      innodb_sys_tablespace_encrypt OFF
      innodb_temp_tablespace_encrypt OFF
      innodb_undo_log_encrypt OFF

      ---------------------------------------+

      For the sake of uniformity, the default value must be in uppercase "OFF"

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              zsolt.parragi Zsolt Parragi
              Reporter:
              mohit.joshi Mohit Joshi
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 1 day, 3 hours, 32 minutes
                  1d 3h 32m

                    Smart Checklist