Uploaded image for project: 'Percona Server for MySQL'
  1. Percona Server for MySQL
  2. PS-7360

Modify clang-4.0 compilation to correct failure from '-Winconsistent-missing-destructor-override'

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: 8.0.21-12
    • Fix Version/s: 8.0.21-12
    • Component/s: None
    • Labels:
      None

      Description

      /home/travis/build/percona/percona-server/router/src/protobuf/src/protobuf_plugin.cc:31:1: error: 
            unknown warning group '-Winconsistent-missing-destructor-override',
            ignored [-Werror,-Wunknown-pragmas]
      MY_COMPILER_CLANG_DIAGNOSTIC_IGNORE(
      ^
      /home/travis/build/percona/percona-server/include/my_compiler.h:219:3: note: 
            expanded from macro 'MY_COMPILER_CLANG_DIAGNOSTIC_IGNORE'
        MY_COMPILER_CPP11_PRAGMA(clang diagnostic ignored X)
        ^
      /home/travis/build/percona/percona-server/include/my_compiler.h:175:37: note: 
            expanded from macro 'MY_COMPILER_CPP11_PRAGMA'
      #define MY_COMPILER_CPP11_PRAGMA(X) _Pragma(#X)
                                          ^
      <scratch space>:21:27: note: expanded from here
       clang diagnostic ignored "-Winconsistent-missing-destructor-override"
      

      The issue is that "-Winconsistent-missing-destructor-override" is not supported by "clang-4.0" or older.

        Attachments

          Activity

            People

            Assignee:
            przemyslaw.skibinski Przemyslaw Skibinski
            Reporter:
            przemyslaw.skibinski Przemyslaw Skibinski
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - Not Specified
                Not Specified
                Logged:
                Time Spent - 1 hour, 15 minutes
                1h 15m

                  Smart Checklist