Uploaded image for project: 'Percona Toolkit'
  1. Percona Toolkit
  2. PT-1296

LP #1482783: Documentation bug on pt-osc --check-plan?

    XMLWordPrintable

    Details

      Description

      **Reported in Launchpad by Peiran last update 15-09-2015 07:22:22

      In the documentation https://www.percona.com/doc/percona-toolkit/2.2/pt-online-schema-change.html, for --check-plan, it mentioned a couple times that the tool could potentially skip chunks. If the tool indeed would skip copying certain chunks instead of error out, it would be too dangerous to use in production.

      Here are the blurbs from the doc:
      " If it appears that MySQL will use a bad query execution plan, the tool will skip the chunk of the table."

      "The tool remembers the largest key_len seen, and skips chunks where MySQL reports that it will use a smaller prefix of the index. This heuristic can be understood as skipping chunks that have a worse execution plan than other chunks."

      "The tool prints a warning the first time a chunk is skipped due to a bad execution plan in each table. Subsequent chunks are skipped silently, although you can see the count of skipped chunks in the SKIPPED column in the tools output."

      From a quick look into the code, it looks like every time check-plan fails, it calls "die()" to terminate the job. I would like to double check that "skip chunk" is just a documentation bug.

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            lpjirasync lpjirasync (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:

                Smart Checklist