Uploaded image for project: 'Percona Toolkit'
  1. Percona Toolkit
  2. PT-2142

Fix tests for pt-config-diff

Details

    • Improvement
    • Status: Done
    • Medium
    • Resolution: Fixed
    • 3.5.0
    • 3.5.1
    • None
    • None
    • Yes
    • Yes
    • 2

    Description

      How to Repeat

      Results are for PS 5.7.40.

      $ prove -vw --trap --timer t/pt-config-diff/
      ...
      [17:31:50] t/pt-config-diff/basics.t ..... 
      ok 1 - Server active config doesn't differ with itself
      ok 2 - No output when no diff
      ok 3 - Exit 1 when diffs found
      ok 4 - Diff output
      not ok 5 - my.sandbox.cnf doesn't differ with active config
      
      #   Failed test 'my.sandbox.cnf doesn't differ with active config'
      #   at t/pt-config-diff/basics.t line 90.
      #          got: '1'
      #     expected: '0'
      not ok 6 - No output
      
      #   Failed test 'No output'
      #   at t/pt-config-diff/basics.t line 96.
      #          got: '1 config difference
      # Variable                  /tmp/12345/my.sandbox.cnf Delly-7390
      # ========================= ========================= ==========
      # innodb_buffer_pool_size   16777216                  2147483648
      # '
      #     expected: ''
      ...
      # Looks like you failed 2 tests of 15.
      Dubious, test returned 2 (wstat 512, 0x200)
      Failed 2/15 subtests 
      

      Suggested Fix

      Identify which tests fail, because badly written and which show real issues with code, fix either tests or code.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              sveta.smirnova Sveta Smirnova
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Smart Checklist