Uploaded image for project: 'Percona Toolkit'
  1. Percona Toolkit
  2. PT-899

LP #897685: Special pt-query-digest fingerprints no longer work

    XMLWordPrintable

    Details

      Description

      **Reported in Launchpad by Baron Schwartz last update 02-08-2013 21:43:42

      In the fingerprint() subroutine, we have:

      $query =~ m#/*\w+\.\w+:[0-9]/[0-9]*/# # pt-table-checksum, etc query
      && return 'percona-toolkit';

      But in other tools, I doubt we have tests to ensure that they don't get changed in a way that will break these expectations. We should test the other tools to prevent this problem. In addition, I worry that this pattern is generic – it is the type of thing that any application could put into a query comment. We should make our tools put a specific comment into their queries, like /* pt-table-checksum .......... */ and the pattern should pull out the tool's name and return that as the fingerprint.

      Also, in pt-query-digest, we are not exposing to the user the fact that a given class of queries is a special case. We might want to address this in a separate bug report though.

        Smart Checklist

          Attachments

            Activity

              People

              Assignee:
              Unassigned
              Reporter:
              lpjirasync lpjirasync (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: