Uploaded image for project: 'Percona XtraBackup'
  1. Percona XtraBackup
  2. PXB-1493

XtraBackup does not check validity on arguments used.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 8.0.7
    • Component/s: None
    • Labels:
      None

      Description

      One can use non-existing arguments, and the tool won't fail:

      [root@pxc-1 ~]# xtrabackup --backup --non-existent-argument --target-dir=/backups/
      180122 21:15:16 version_check Connecting to MySQL server with DSN 'dbi:mysql:;mysql_read_default_group=xtrabackup' (using password: NO).
      180122 21:15:16 version_check Connected to MySQL server
      180122 21:15:16 version_check Executing a version check against the server...
      180122 21:15:16 version_check Done.
      180122 21:15:16 Connecting to MySQL server host: localhost, user: not set, password: not set, port: not set, socket: not set
      Using server version 5.7.19-17-57
      xtrabackup version 2.4.9 based on MySQL server 5.7.13 Linux (x86_64) (revision id: a467167cdd4)
      xtrabackup: uses posix_fadvise().
      xtrabackup: cd to /var/lib/mysql
      xtrabackup: open files limit requested 0, set to 1024
      xtrabackup: using the following InnoDB configuration:
      xtrabackup: innodb_data_home_dir = .
      xtrabackup: innodb_data_file_path = ibdata1:12M:autoextend
      xtrabackup: innodb_log_group_home_dir = ./
      xtrabackup: innodb_log_files_in_group = 2
      xtrabackup: innodb_log_file_size = 50331648
      InnoDB: Number of pools: 1
      180122 21:15:16 >> log scanned up to (13891914)
      xtrabackup: Generating a list of tablespaces
      InnoDB: Allocated tablespace ID 21 for sys/sys_config, old maximum was 0
      180122 21:15:16 [01] Copying ./ibdata1 to /backups/ibdata1
      180122 21:15:16 [01] ...done
      
      [output trimmed]
      
      180122 21:15:18 Finished backing up non-InnoDB tables and files
      180122 21:15:18 Executing FLUSH NO_WRITE_TO_BINLOG ENGINE LOGS...
      xtrabackup: The latest check point (for incremental): '13891905'
      xtrabackup: Stopping log copying thread.
      .180122 21:15:18 >> log scanned up to (13891914)
      
      180122 21:15:18 Executing UNLOCK TABLES
      180122 21:15:18 All tables unlocked
      180122 21:15:18 [00] Copying ib_buffer_pool to /backups/ib_buffer_pool
      180122 21:15:18 [00] ...done
      180122 21:15:18 Backup created in directory '/backups/'
      180122 21:15:18 [00] Writing /backups/backup-my.cnf
      180122 21:15:18 [00] ...done
      180122 21:15:18 [00] Writing /backups/xtrabackup_info
      180122 21:15:18 [00] ...done
      xtrabackup: Transaction log of lsn (13891905) to (13891914) was copied.
      180122 21:15:18 completed OK!

      As we can see above, neither errors nor warnings were output. 

       

      Version used (current latest as of this writing):

      [root@pxc-1 ~]# xtrabackup --version
      xtrabackup version 2.4.9 based on MySQL server 5.7.13 Linux (x86_64) (revision id: a467167cdd4)
      

       

      This can create a lot of confusion, in the following scenario, for instance:

      xtrabackup --backup --ddl-lock --target-dir=/backups/

      The backup will complete OK, but instead of using the --lock-ddl functionality, the tool will silently go on, and the LOCK TABLES FOR BACKUP will not be used at the beginning.

       

       

        Smart Checklist

          Attachments

            Issue Links

              Activity

                People

                Assignee:
                sergei.glushchenko Sergei Glushchenko (Inactive)
                Reporter:
                agustin.gallego Agustín Gallego
                Votes:
                2 Vote for this issue
                Watchers:
                4 Start watching this issue

                  Dates

                  Created:
                  Updated:
                  Resolved:

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - Not Specified
                    Not Specified
                    Logged:
                    Time Spent - 2 days, 8 minutes
                    2d 8m