Uploaded image for project: 'Percona XtraBackup'
  1. Percona XtraBackup
  2. PXB-1979

Enable --lock-ddl by default to prevent corruption of the backup

Details

    • Improvement
    • Status: Done
    • Medium
    • Resolution: Fixed
    • 8.0.x
    • 8.0.23-16 (Q1 2021)
    • None
    • None

    Description

      Without "--lock-ddl" option and concurrent DDLs happening, PXB allows you to take backup but these are invalid backups. They fail at xb prepare stage

      So if some DDL happened during  backup without the knowledge of user, he might think the backup succeeded. The backup taken is corrupted.

      For example, see bugs: PXB-1974 PXB-1972 PXB-1969. These are just few bugs with CREATE and TRUNCATE in progress during backup.

      with  ALTER TABLE, there could be many more issues

      Suggestion:

      1) Enable lock-ddl by default

      2) Evaluate the locking overhead. If it is in acceptable range (say 5%), enable it

      3) Ensure that DMLs can continue to happen with DDL locks taken (they are only supposed to block DDLs, not DMLs)

       

      Attachments

        Issue Links

          Activity

            People

              rahul.malik Rahul Malik
              satya.bodapati Satya Bodapati
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 6 hours, 15 minutes
                  6h 15m

                  Smart Checklist