-
Type:
Bug
-
Status: Done
-
Priority:
Medium
-
Resolution: Fixed
-
Affects Version/s: 5.7.x, Not 5.5.x, Not 5.6.x
-
Fix Version/s: 5.7.21-21
-
Component/s: None
-
Labels:
PS-3360 was developed when LRU flusher was performed by the page cleaners, before its flushing was split to separate threads. Now its logic is outdated and the comment invalid:
diff --git a/storage/innobase/buf/buf0flu.cc b/storage/innobase/buf/buf0flu.cc index c7672a6137e..443740ac200 100644 --- a/storage/innobase/buf/buf0flu.cc +++ b/storage/innobase/buf/buf0flu.cc @@ -3385,7 +3385,13 @@ DECLARE_THREAD(buf_flush_page_cleaner_coordinator)( n_flushed = n_processed_lru; - if (ut_time_ms() > next_loop_time) + if (ut_time_ms() > next_loop_time + && ret_sleep != OS_SYNC_TIME_EXCEEDED) + + /* If our LRU flush took too long, skip the rest only + if the last iteration completed in time, otherwise we'd + be LRU flushing all the time, even if e.g. a sync flush + is waiting. */ ret_sleep = OS_SYNC_TIME_EXCEEDED; else if (ret_sleep != OS_SYNC_TIME_EXCEEDED && srv_flush_sync
Analyze and revert.
- has to be done before
-
PS-269 Initial Percona Server port to MySQL 8
-
- Done
-
